Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node pool options cannot be set to false #2187

Conversation

TPXP
Copy link
Contributor

@TPXP TPXP commented Nov 15, 2024

terraform's toset seems to strip falsy values from maps (at least, that's what we're seeing with terraform 1.9.8), so setting auto_repair to false is not passed through and ends up taking the default true value.

Use a for expression instead, it's simpler and works too

terraform's toset seems to strip falsy values from maps.

Use a for expression instead, it's simpler and works too
@TPXP TPXP requested review from ericyz, gtsorbo and a team as code owners November 15, 2024 17:42
@TPXP TPXP changed the title fix: node pool options cannot be set to falsy fix: node pool options cannot be set to false Nov 15, 2024
@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @TPXP!

@apeabody apeabody merged commit 752db66 into terraform-google-modules:master Nov 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants