Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TPG>=6.5.0)!: promote enable_gcfs to GA #2178

Merged

Conversation

wyardley
Copy link
Contributor

promote enable_gcfs to GA in main module

@wyardley wyardley requested review from ericyz, gtsorbo and a team as code owners November 12, 2024 18:33
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody self-assigned this Nov 12, 2024
@wyardley wyardley changed the title feat(TPG>=6.5.0): promote enable_gcfs to GA feat(TPG>=6.5.0)!: promote enable_gcfs to GA Nov 12, 2024
@wyardley
Copy link
Contributor Author

Was the test failure related to the changes?

@apeabody
Copy link
Collaborator

Was the test failure related to the changes?

I don't think so, started seeing this yesterday in several PRs:

Step #48 - "destroy workload-metadata-config-local":        
Step #48 - "destroy workload-metadata-config-local":        Error: Failed to parse value for host: https://
Step #48 - "destroy workload-metadata-config-local":        
Step #48 - "destroy workload-metadata-config-local":          with module.example.provider["registry.terraform.io/hashicorp/kubernetes"],
Step #48 - "destroy workload-metadata-config-local":          on ../../../examples/workload_metadata_config/main.tf line 23, in provider "kubernetes":
Step #48 - "destroy workload-metadata-config-local":          23: provider "kubernetes" {
Step #48 - "destroy workload-metadata-config-local":        
Step #48 - "destroy workload-metadata-config-local":        host must be a URL or a host:port pair: "https://"
Step #48 - "destroy workload-metadata-config-local": >>>>>> Expected process to exit with [0], but received '1'

@apeabody
Copy link
Collaborator

apeabody commented Nov 13, 2024

Was the test failure related to the changes?

I don't think so, started seeing this yesterday in several PRs:

Step #48 - "destroy workload-metadata-config-local":        
Step #48 - "destroy workload-metadata-config-local":        Error: Failed to parse value for host: https://
Step #48 - "destroy workload-metadata-config-local":        
Step #48 - "destroy workload-metadata-config-local":          with module.example.provider["registry.terraform.io/hashicorp/kubernetes"],
Step #48 - "destroy workload-metadata-config-local":          on ../../../examples/workload_metadata_config/main.tf line 23, in provider "kubernetes":
Step #48 - "destroy workload-metadata-config-local":          23: provider "kubernetes" {
Step #48 - "destroy workload-metadata-config-local":        
Step #48 - "destroy workload-metadata-config-local":        host must be a URL or a host:port pair: "https://"
Step #48 - "destroy workload-metadata-config-local": >>>>>> Expected process to exit with [0], but received '1'

Looks like with v6.11.0 container_cluster endpoint is no longer populate with cluster's with private endpoints.

@wyardley
Copy link
Contributor Author

Hmm, maybe related to hashicorp/terraform-provider-google#20193?

@apeabody
Copy link
Collaborator

Hmm, maybe related to hashicorp/terraform-provider-google#20193?

Yeah - Looking at a potential solution: #2180

@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @wyardley!

@apeabody apeabody merged commit eb9b0be into terraform-google-modules:master Nov 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants