Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary lookup for safer_cluster nodepool ID #2160

Merged

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Oct 29, 2024

Resolve tflint error on an unecessary lookup() call in safer_cluster node pool IDs.

each.key should function properly here, since the name is the key for each of the maps in the map of maps, though each.value.name should work as well.

I could use format() instead of string interpolation instead if it's preferred.

BEGIN_COMMIT_OVERRIDE
fix: remove unnecessary lookup for safer_cluster nodepool ID (#2160)
END_COMMIT_OVERRIDE

Resolve tflint error on an unecessary `lookup()` call in safer_cluster
node pool IDs.

`each.key` should function properly here, since the name is the key for
each of the maps in the map of maps, though `each.value.name` should
work as well.
@wyardley wyardley requested review from ericyz, gtsorbo and a team as code owners October 29, 2024 17:57
@apeabody
Copy link
Collaborator

/gcbrun

@wyardley
Copy link
Contributor Author

Tested planning this locally and seems like it should still work? What was the failure on this one?

@apeabody
Copy link
Collaborator

apeabody commented Oct 29, 2024

Tested planning this locally and seems like it should still work? What was the failure on this one?

Yeah, it's unrelated to the change, started seeing this in the CI tests today:

Step #43 - "apply simple-zonal-private-local":         	Error:      	Received unexpected error:
Step #43 - "apply simple-zonal-private-local":         	            	FatalError{Underlying: error while running command: exit status 1; 
Step #43 - "apply simple-zonal-private-local":         	            	Error: Error waiting to create Network: Error waiting for Creating Network: Quota 'NETWORKS' exceeded.  Limit: 5.0 globally.
Step #43 - "apply simple-zonal-private-local":         	            		metric name = compute.googleapis.com/networks
Step #43 - "apply simple-zonal-private-local":         	            		limit name = NETWORKS-per-project
Step #43 - "apply simple-zonal-private-local":         	            		limit = 5
Step #43 - "apply simple-zonal-private-local":         	            		dimensions = map[global:global]
Step #43 - "apply simple-zonal-private-local":         	            	
Step #43 - "apply simple-zonal-private-local":         	            	
Step #43 - "apply simple-zonal-private-local":         	            	  with google_compute_network.main,
Step #43 - "apply simple-zonal-private-local":         	            	  on network.tf line 24, in resource "google_compute_network" "main":
Step #43 - "apply simple-zonal-private-local":         	            	  24: resource "google_compute_network" "main" {
Step #43 - "apply simple-zonal-private-local":         	            	}
Step #43 - "apply simple-zonal-private-local":         	Test:       	TestSimpleZonalPrivate

I'll re-run the tests tomorrow.

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody self-assigned this Oct 30, 2024
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody enabled auto-merge (squash) October 30, 2024 19:27
@apeabody apeabody disabled auto-merge October 30, 2024 20:43
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wyardley!

@apeabody apeabody merged commit 179a8ec into terraform-google-modules:master Oct 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants