-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix typo in kube-dns-upstream-nameservers configmap #2149
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @MaximF!
Please update the template so this is also changed in the sub-modules: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/CONTRIBUTING.md#templating
@apeabody Thanks for referencing. I made the change to the template and regenerated all the dependencies. |
/gcbrun |
Hi @MaximF - What will be the impact to current users? Would it make sense to include: https://developer.hashicorp.com/terraform/language/v1.3.x/moved |
/gcbrun |
fix: fix typo in kube-dns-upstream-nameservers configmap
feat: use 'moved' block to address ConfigMap renaming chore: remove extra empty line
Thanks @apeabody. I just added a |
/gcbrun |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @MaximF!
Fix typo for a configmap resource name from
kube-dns-upstream-namservers
tokube-dns-upstream-nameservers
.