Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix typo in kube-dns-upstream-nameservers configmap #2149

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

MaximF
Copy link
Contributor

@MaximF MaximF commented Oct 18, 2024

Fix typo for a configmap resource name from kube-dns-upstream-namservers to kube-dns-upstream-nameservers.

@MaximF MaximF requested review from ericyz, gtsorbo and a team as code owners October 18, 2024 21:23
Copy link

google-cla bot commented Oct 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @MaximF!

Please update the template so this is also changed in the sub-modules: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/CONTRIBUTING.md#templating

@MaximF MaximF requested a review from apeabody October 19, 2024 21:17
@MaximF
Copy link
Contributor Author

MaximF commented Oct 19, 2024

@apeabody Thanks for referencing. I made the change to the template and regenerated all the dependencies.
Please take a look.

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody self-assigned this Oct 21, 2024
@apeabody
Copy link
Collaborator

Hi @MaximF - What will be the impact to current users? Would it make sense to include: https://developer.hashicorp.com/terraform/language/v1.3.x/moved

@apeabody
Copy link
Collaborator

/gcbrun

MaximF and others added 2 commits October 21, 2024 16:22
fix: fix typo in kube-dns-upstream-nameservers configmap
feat: use 'moved' block to address ConfigMap renaming

chore: remove extra empty line
@MaximF
Copy link
Contributor Author

MaximF commented Oct 21, 2024

Thanks @apeabody. I just added a moved block there.

@apeabody
Copy link
Collaborator

/gcbrun

autogen/main/dns.tf.tmpl Outdated Show resolved Hide resolved
@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @MaximF!

@apeabody apeabody merged commit 843c56c into terraform-google-modules:master Oct 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants