Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: correct confidential node field name #2140

Merged

Conversation

redoak666
Copy link
Contributor

The field name confidential_node in dynamic block confidential_nodes at nodepool level is incorrect, it should be enabled_confidential_nodes
dynamic "confidential_nodes" {
for_each = lookup(each.value, "enable_confidential_nodes", null) != null ? [each.value.confidential_nodes] : []
content {
enabled = confidential_nodes.value
}

@redoak666 redoak666 requested review from ericyz, gtsorbo and a team as code owners October 16, 2024 21:03
Copy link

google-cla bot commented Oct 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@redoak666 redoak666 changed the title correct confidential node field name Fix: correct confidential node field name Oct 16, 2024
@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@redoak666 redoak666 force-pushed the fix/confidential-nodepool branch from 303953f to 5664ed3 Compare October 16, 2024 22:51
@redoak666
Copy link
Contributor Author

@apeabody
updated per instruction

@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @redoak666!

@apeabody apeabody merged commit 373c969 into terraform-google-modules:master Oct 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants