fix(node_pools): Update Variants: Add recreate for secondary_boot_disk and local_ssd_ephemeral_count (beta)
#2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…phemeral_count (beta)
zepellin
changed the title
secondary_boot_disk and local_ssd_ephemeral_count (beta)secondary_boot_disk and local_ssd_ephemeral_count (beta)
|
/gcbrun |
zepellin
deleted the
np-secondary-boot-disks-recreate-on-update-variant
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code in this PR forces re-creation of node pools with changes in
secondary_boot_diskandlocal_ssd_ephemeral_count(for beta variants). Because of these are currently not inrandom_id.namekeepers, the random suffix (and the entire node pool name) remains the same on updating these variables and replacing node pool resource results inresource - <node_pool_path> - already existserror.Both of these parameters require node pool re-creation as per TF spec:
secondary_boot_disk: secondary_boot_diskslocal_ssd_ephemeral_count: ephemeral_storage_local_ssd_config