Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TPG>=6.5.0)!: support gcp_filestore_csi_driver_config for autopilot #2126

Merged

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Oct 2, 2024

@DrFaust92 DrFaust92 requested review from ericyz, gtsorbo and a team as code owners October 2, 2024 03:47
@DrFaust92 DrFaust92 changed the title support gcp_filestore_csi_driver_config for autopilot feat: support gcp_filestore_csi_driver_config for autopilot Oct 2, 2024
@apeabody
Copy link
Collaborator

apeabody commented Oct 2, 2024

/gcbrun

@apeabody
Copy link
Collaborator

apeabody commented Oct 2, 2024

/gcbrun

@apeabody
Copy link
Collaborator

apeabody commented Oct 3, 2024

/gcbrun

@DrFaust92
Copy link
Contributor Author

apeabody can you share the error?

@apeabody
Copy link
Collaborator

apeabody commented Oct 4, 2024

apeabody can you share the error?

I'm pretty sure this was a flake, re-running the tests.

@apeabody
Copy link
Collaborator

apeabody commented Oct 4, 2024

/gcbrun

@DrFaust92
Copy link
Contributor Author

apeabody still seems to fail 😢

@apeabody
Copy link
Collaborator

apeabody commented Oct 7, 2024

apeabody still seems to fail 😢

Doesn't appear related to your change, working on it here: #2130

@apeabody
Copy link
Collaborator

apeabody commented Oct 7, 2024

/gcbrun

@apeabody apeabody changed the title feat: support gcp_filestore_csi_driver_config for autopilot feat(TPG>=6.5.0)!: support gcp_filestore_csi_driver_config for autopilot Oct 8, 2024
@apeabody
Copy link
Collaborator

apeabody commented Oct 8, 2024

This will be a breaking change, updated the subject and marked as do not merge for now.

@apeabody
Copy link
Collaborator

apeabody commented Oct 9, 2024

/gcbrun

1 similar comment
@apeabody
Copy link
Collaborator

apeabody commented Oct 9, 2024

/gcbrun

@apeabody
Copy link
Collaborator

apeabody commented Oct 9, 2024

/gcbrun

1 similar comment
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

Given the removal of TPGv5 support, going to hold this for the v35 breaking release.

@apeabody apeabody self-assigned this Oct 23, 2024
@apeabody apeabody added the triaged Scoped and ready for work label Oct 25, 2024
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

Thanks for the contribution @DrFaust92!

@apeabody apeabody merged commit e3f016e into terraform-google-modules:master Oct 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Scoped and ready for work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants