fix: correct gcfs_config value #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeabody
changed the title
apeabody
force-pushed
the
ap/tobool
branch
2 times, most recently
from
6866b00 to
7855222
Compare
wyardley
approved these changes
Sep 13, 2024
wyardley
reviewed
Sep 13, 2024
| @@ -51,6 +51,7 @@ module "gke" { | |||
| max_count = 2 | |||
| service_account = var.compute_engine_service_account | |||
| auto_upgrade = true | |||
| enable_gcfs = false | |||
There was a problem hiding this comment.
🙏 for adding an example so it'll get tested as well.
bharathkkb
approved these changes
Sep 13, 2024
wyardley
added a commit
to wyardley/terraform-google-kubernetes-engine
that referenced
this pull request
Sep 23, 2024
Fixes terraform-google-modules#2100 This basically replicates the fixes from terraform-google-modules#2093, terraform-google-modules#2095, but at the scope of implicitly defined nodepools.
wyardley
added a commit
to wyardley/terraform-google-kubernetes-engine
that referenced
this pull request
Sep 23, 2024
Fixes terraform-google-modules#2100 This basically replicates the fixes from terraform-google-modules#2093, terraform-google-modules#2095, but at the scope of implicitly defined nodepools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.