Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no gcfs block when enable_gcfs null #2093

Merged
merged 2 commits into from
Sep 13, 2024
Merged

fix: no gcfs block when enable_gcfs null #2093

merged 2 commits into from
Sep 13, 2024

Conversation

apeabody
Copy link
Collaborator

@apeabody apeabody commented Sep 12, 2024 •
edited
Loading

Fixes: #2048

@apeabody apeabody requested review from ericyz, gtsorbo and a team as code owners September 12, 2024 23:13
@apeabody apeabody changed the title fix: no gcfs block when null fix: no gcfs block when enable_gcfs null Sep 12, 2024
@apeabody apeabody mentioned this pull request Sep 13, 2024
Closed
@apeabody apeabody enabled auto-merge (squash) September 13, 2024 15:40
@apeabody apeabody merged commit f4c1af2 into master Sep 13, 2024
8 checks passed
@apeabody apeabody deleted the ap/gcfs branch September 13, 2024 16:37
@release-please release-please bot mentioned this pull request Sep 13, 2024
Merged
wyardley added a commit to wyardley/terraform-google-kubernetes-engine that referenced this pull request Sep 13, 2024
@wyardley
fix(main): set defaults for enable_gcfs
47f614d 
Fixes terraform-google-modules#2048, followup to terraform-google-modules#2093
wyardley added a commit to wyardley/terraform-google-kubernetes-engine that referenced this pull request Sep 23, 2024
@wyardley
fix: allow null enable_gcfs setting in defined nodepools
42ce927 
Fixes terraform-google-modules#2100
This basically replicates the fixes from terraform-google-modules#2093, terraform-google-modules#2095, but at the scope
of implicitly defined nodepools.
@wyardley wyardley mentioned this pull request Sep 23, 2024
Merged
wyardley added a commit to wyardley/terraform-google-kubernetes-engine that referenced this pull request Sep 23, 2024
@wyardley
fix: allow null enable_gcfs setting in defined nodepools
ee27b75 
Fixes terraform-google-modules#2100
This basically replicates the fixes from terraform-google-modules#2093, terraform-google-modules#2095, but at the scope
of implicitly defined nodepools.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

@gtsorbo gtsorbo Awaiting requested review from gtsorbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gcfs_config variable forces replacement
2 participants
@apeabody @bharathkkb