Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow enable_private_endpoint with no master_authorized_networks #2058

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix: allow enable_private_endpoint with no master_authorized_networks #2058

merged 1 commit into from
Aug 26, 2024

Conversation

apeabody
Copy link
Collaborator

@apeabody apeabody commented Aug 23, 2024 •
edited
Loading

  • allow private cluster's enable_private_endpoint with no master_authorized_networks
  • add test coverage

@apeabody apeabody requested review from ericyz, gtsorbo and a team as code owners August 23, 2024 20:29
@apeabody apeabody force-pushed the ap/auth_networks branch 2 times, most recently from 4a45f3a to ad5de1b Compare August 23, 2024 21:29
@apeabody apeabody merged commit 528b373 into master Aug 26, 2024
8 checks passed
@apeabody apeabody deleted the ap/auth_networks branch August 26, 2024 17:18
@release-please release-please bot mentioned this pull request Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

@gtsorbo gtsorbo Awaiting requested review from gtsorbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apeabody @bharathkkb