Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fleet_app_operator_permissions): optional groups and users #2044

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix(fleet_app_operator_permissions): optional groups and users #2044

merged 1 commit into from
Aug 20, 2024

Conversation

apeabody
Copy link
Collaborator

@apeabody apeabody commented Aug 20, 2024 •
edited
Loading

Enable groups and users parameters to be optional.

@apeabody apeabody marked this pull request as ready for review August 20, 2024 16:31
@apeabody apeabody requested review from ericyz, gtsorbo and a team as code owners August 20, 2024 16:31
hosseingolestani
hosseingolestani approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@hosseingolestani hosseingolestani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@apeabody apeabody merged commit a5a67e5 into master Aug 20, 2024
8 checks passed
@apeabody apeabody deleted the ap/optional-pincripals branch August 20, 2024 17:40
@release-please release-please bot mentioned this pull request Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hosseingolestani hosseingolestani hosseingolestani approved these changes

@bharathkkb bharathkkb bharathkkb approved these changes

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

@gtsorbo gtsorbo Awaiting requested review from gtsorbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apeabody @bharathkkb @hosseingolestani