Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip service account random_string when not needed #2024

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

Bo98
Copy link
Contributor

@Bo98 Bo98 commented Aug 5, 2024

The random_string resource is only used to create the default service account name. It is not needed when not creating a service account or when using a custom service account name.

Fixes #1808
Fixes #1690

@Bo98 Bo98 requested review from ericyz, gtsorbo and a team as code owners August 5, 2024 15:42
@apeabody apeabody self-assigned this Aug 5, 2024
@apeabody
Copy link
Collaborator

apeabody commented Aug 5, 2024

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @Bo98!

@apeabody
Copy link
Collaborator

apeabody commented Aug 5, 2024

/gcbrun

@apeabody apeabody merged commit be88d19 into terraform-google-modules:master Aug 5, 2024
4 checks passed
@Bo98 Bo98 deleted the no-random_string branch August 5, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants