feat: support enable_nested_virtualization

[DrFaust92]

No description provided.

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[apeabody]

Thanks for the contribution @DrFaust92!

This change looks OK to me, could we add to a appropriate example/test?

[DrFaust92]

apeabody tried to add a test, hope this is well

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[DrFaust92]

Hi apeabody, can you share the error?

[apeabody]

Hi apeabody, can you share the error?

Hmm, unfortunately it didn't accept the null for threads_per_core. Perhaps the original "0" or "" are considered "unset"? I'll need to investigate further and perhaps get the documentation updated.

"The number of threads per physical core. To disable simultaneous multithreading (SMT) set this to 1. If unset, the maximum number of threads supported per core by the underlying processor is assumed."

Step #67 - "converge node-pool-local": STDERR: Error: Missing required argument
Step #67 - "converge node-pool-local": 
Step #67 - "converge node-pool-local":   with module.example.module.gke.google_container_node_pool.pools["pool-05"],
Step #67 - "converge node-pool-local":   on ../../../modules/beta-public-cluster/cluster.tf line 637, in resource "google_container_node_pool" "pools":
Step #67 - "converge node-pool-local":  637:   node_config {
Step #67 - "converge node-pool-local": 
Step #67 - "converge node-pool-local": The argument "node_config.0.advanced_machine_features.0.threads_per_core" is
Step #67 - "converge node-pool-local": required, but no definition was found.

[DrFaust92]

apeabody probably zero us unset as its an int and in golang many times its as good as unset

[apeabody]

apeabody probably zero us unset as its an int and in golang many times its as good as unset

Agreed, "0" is my educated guess as well. We can go forward with that value for now if you like.

[apeabody]

/gcbrun

[apeabody]

/gcbrun