feat: add optional private_endpoint_subnetwork variable in private submodules

[pib]

Fixes #1987

[apeabody]

/gcbrun

[apeabody]

Thanks for the contribution @pib!

Can you please rebase.

[apeabody]

/gcbrun

[apeabody]

Thanks @pib! - From the PR title is the intention to only add for beta submodules? Currently it appears this is being added for all private clusters? To add for just beta you can enclose the new code section in {% if beta_cluster %} {% endif %}.

[pib]

Thanks @pib! - From the PR title is the intention to only add for beta submodules? Currently it appears this is being added for all private clusters? To add for just beta you can enclose the new code section in {% if beta_cluster %} {% endif %}.

Ah, based on issue #1987 I had assumed that field was only available in the beta provider, but I see it is available in the non-beta provider as well, so really it should just be "in private submodules".

[pib]

@apeabody should I also amend the commit so it has the correct message? I'm not sure if release-please will use the PR title or the actual commit message.

[apeabody]

@apeabody should I also amend the commit so it has the correct message? I'm not sure if release-please will use the PR title or the actual commit message.

Thanks! We always squash merge, so it will use the title of the PR (not the commits).

[apeabody]

/gcbrun

[pib]

@apeabody should I also amend the commit so it has the correct message? I'm not sure if release-please will use the PR title or the actual commit message.

Thanks! We always squash merge, so it will use the title of the PR (not the commits).

Ah well, I had to rebase again anyway :D

[pib]

Whoops, sorry, that "Close with comment" button is really close to the "Comment" button :|

[apeabody]

Whoops, sorry, that "Close with comment" button is really close to the "Comment" button :|

Agreed, I've done that by accident more than once!

[apeabody]

/gcbrun