Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow default node pools metadata key-value pairs to be disabled #2005

Conversation

caueasantos
Copy link
Contributor

@caueasantos caueasantos commented Jul 23, 2024

Resolves #2004

There are many ways to go about this, but I tried to quickly expose a way for users to disable default metadata labels added by the module.

First time opening a pull request here, let me know if I missed anything.

@caueasantos caueasantos requested review from ericyz, gtsorbo and a team as code owners July 23, 2024 21:49
Copy link

google-cla bot commented Jul 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @caueasantos!

Should this change apply to Autopilot cluster?

Working in ./modules/beta-autopilot-private-cluster ...
1 issue(s) found:

Warning: [Fixable] variable "enable_default_node_pools_metadata" is declared but not used (terraform_unused_declarations)

  on variables.tf line 427:
 427: variable "enable_default_node_pools_metadata" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.7.0/docs/rules/terraform_unused_declarations.md

tflint failed ./modules/beta-autopilot-private-cluster 
Working in ./modules/beta-autopilot-public-cluster ...
1 issue(s) found:

Warning: [Fixable] variable "enable_default_node_pools_metadata" is declared but not used (terraform_unused_declarations)

  on variables.tf line 397:
 397: variable "enable_default_node_pools_metadata" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.7.0/docs/rules/terraform_unused_declarations.md

tflint failed ./modules/beta-autopilot-public-cluster 

@caueasantos
Copy link
Contributor Author

Thanks for the contribution @caueasantos!

Should this change apply to Autopilot cluster?

Working in ./modules/beta-autopilot-private-cluster ...
1 issue(s) found:

Warning: [Fixable] variable "enable_default_node_pools_metadata" is declared but not used (terraform_unused_declarations)

  on variables.tf line 427:
 427: variable "enable_default_node_pools_metadata" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.7.0/docs/rules/terraform_unused_declarations.md

tflint failed ./modules/beta-autopilot-private-cluster 
Working in ./modules/beta-autopilot-public-cluster ...
1 issue(s) found:

Warning: [Fixable] variable "enable_default_node_pools_metadata" is declared but not used (terraform_unused_declarations)

  on variables.tf line 397:
 397: variable "enable_default_node_pools_metadata" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.7.0/docs/rules/terraform_unused_declarations.md

tflint failed ./modules/beta-autopilot-public-cluster 

Definitely not, let me see how I can disable the variable for autopilot clusters using the autogeneration templates.

@caueasantos caueasantos requested a review from apeabody July 25, 2024 15:38
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody self-assigned this Jul 25, 2024
caueasantos and others added 2 commits July 25, 2024 12:18
@caueasantos caueasantos requested a review from apeabody July 25, 2024 18:32
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody merged commit 318f38f into terraform-google-modules:master Jul 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing node pools can forces replacement
2 participants