feat(cluster.tf): add support for setting cgroup mode

[DrFaust92]

Fix #1838
Supersedes #1891

seeing if i can push it over the finish line

[DrFaust92]

there is probably some other issue here based on the previous PR but lets check and see. ill fix as needed

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[apeabody]

From INT:

Error: expected node_config.0.linux_node_config.0.cgroup_mode to be one of ["CGROUP_MODE_UNSPECIFIED" "CGROUP_MODE_V1" "CGROUP_MODE_V2"], got 

  with module.example.module.gke.google_container_node_pool.pools["pool-03"],
  on ../../../modules/beta-public-cluster/cluster.tf line 637, in resource "google_container_node_pool" "pools":
 637:   node_config {

Probably need to default to null rather than an empty string.

[DrFaust92]

@apeabody i wonder if this needs to be CGROUP_MODE_UNSPECIFIED to make it work

[apeabody]

Hi @DrFaust92 - I checked the provider code and cgroup_mode is an (optional) string, but will not accept "". So an option for https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/2001/files#diff-a3a07be3819af6f1a65ed243a613e69b544b7274d248a4b4d7d4d127aec40aeeR1045 would be to check the locals value and if "" instead pass 'null'.

[DrFaust92]

Thanks! Will take a look

…

On Thu, 25 Jul 2024 at 15:34 Andrew Peabody ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In autogen/main/variables_defaults.tf.tmpl <#2001 (comment)> : > @@ -114,5 +114,14 @@ locals { ), var.node_pools_linux_node_configs_sysctls ) + node_pools_cgroup_mode = merge( + { all = "" }, Hi @DrFaust92 <https://github.com/DrFaust92> - I checked the provider code and cgroup_mode is an (optional) string, but will not accept "". So an option for https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/2001/files#diff-a3a07be3819af6f1a65ed243a613e69b544b7274d248a4b4d7d4d127aec40aeeR1045 would be to check the locals value and if "" instead pass 'null'. — Reply to this email directly, view it on GitHub <#2001 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIA2W7XSZLBPOOFLVGGZ5ATZOFHLJAVCNFSM6AAAAABLE34PCCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMBQGIZDSNBZGQ> . You are receiving this because you were mentioned.Message ID: <terraform-google-modules/terraform-google-kubernetes-engine/pull/2001/review/2200229494 @github.com>

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[apeabody]

Thanks for the contribution @DrFaust92!

Confirm cgroup_mode in TPG v5.25.0

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[apeabody]

/gcbrun