Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump identity_service_config to ga #1997

Merged
merged 8 commits into from
Jul 18, 2024
Merged

feat: bump identity_service_config to ga #1997

merged 8 commits into from
Jul 18, 2024

Conversation

DrFaust92
Copy link
Contributor

No description provided.

@DrFaust92 DrFaust92 requested review from ericyz, gtsorbo and a team as code owners July 16, 2024 20:14
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

apeabody
apeabody requested changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @DrFaust92!

autogen/main/variables.tf.tmpl Outdated Show resolved Hide resolved
autogen/main/main.tf.tmpl Outdated Show resolved Hide resolved
autogen/main/outputs.tf.tmpl Show resolved Hide resolved
@DrFaust92 DrFaust92 requested a review from apeabody July 18, 2024 19:07
@DrFaust92
Copy link
Contributor Author

fixing the lint error

@apeabody
Copy link
Collaborator

/gcbrun

apeabody
apeabody approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @DrFaust92!

@apeabody apeabody merged commit 9d6a400 into terraform-google-modules:master Jul 18, 2024
4 checks passed
@release-please release-please bot mentioned this pull request Jul 18, 2024
Merged
@apeabody apeabody mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

@gtsorbo gtsorbo Awaiting requested review from gtsorbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrFaust92 @apeabody