-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: anthos modules remote fleet project #1995
feat: anthos modules remote fleet project #1995
Conversation
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @CPL-markus!
Error: Received unexpected error:
FatalError{Underlying: error while running command: exit status 1;
Error: Failed to retrieve project, pid: , err: project: required field is not set
with module.example.module.acm.google_gke_hub_feature.acm[0],
on ../../../modules/acm/feature.tf line 17, in resource "google_gke_hub_feature" "acm":
17: resource "google_gke_hub_feature" "acm" {
}
Test: TestSimpleZonal
…com:WALTER-GROUP/terraform-google-kubernetes-engine into feature/anthos_modules_remote_fleet_project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, the evaluation of empty strings seems to require coalesce
, instead of try
to ensure the right variable is used.
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @CPL-markus!
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @CPL-markus!
@CPL-markus - Can you please rebase/merge? Thanks! |
@apeabody I rebased it, but merging is blocked as I need your help in running the pipeline again. :-) |
/gcbrun |
It should be possible to enable the ACM feature on a GKE cluster that has its fleet in a separate project.
Therefore an additonal variable
hub_project_id
was introduced to reference the fleet project id. If it is empty (default), theproject_id
variable will be used instead.