Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: anthos modules remote fleet project #1995

Conversation

CPL-markus
Copy link
Contributor

It should be possible to enable the ACM feature on a GKE cluster that has its fleet in a separate project.

Therefore an additonal variable hub_project_id was introduced to reference the fleet project id. If it is empty (default), the project_id variable will be used instead.

@CPL-markus CPL-markus requested review from ericyz, gtsorbo and a team as code owners July 15, 2024 13:59
@CPL-markus
Copy link
Contributor Author

CPL-markus commented Jul 15, 2024

@apeabody Sorry, messed up the old pull-request (#1981) while trying to patch something in Git. Please check this (new) request again.

@CPL-markus CPL-markus changed the title Feature/anthos modules remote fleet project feat: anthos modules remote fleet project Jul 15, 2024
@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @CPL-markus!

        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: exit status 1; 
        	            	Error: Failed to retrieve project, pid: , err: project: required field is not set
        	            	
        	            	  with module.example.module.acm.google_gke_hub_feature.acm[0],
        	            	  on ../../../modules/acm/feature.tf line 17, in resource "google_gke_hub_feature" "acm":
        	            	  17: resource "google_gke_hub_feature" "acm" {
        	            	}
        	Test:       	TestSimpleZonal

…com:WALTER-GROUP/terraform-google-kubernetes-engine into feature/anthos_modules_remote_fleet_project
Copy link
Contributor Author

@CPL-markus CPL-markus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, the evaluation of empty strings seems to require coalesce, instead of try to ensure the right variable is used.

@CPL-markus CPL-markus requested a review from apeabody July 18, 2024 09:14
@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @CPL-markus!

modules/acm/variables.tf Outdated Show resolved Hide resolved
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody self-assigned this Jul 23, 2024
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @CPL-markus!

@apeabody
Copy link
Collaborator

@CPL-markus - Can you please rebase/merge? Thanks!

@CPL-markus
Copy link
Contributor Author

@apeabody I rebased it, but merging is blocked as I need your help in running the pipeline again. :-)

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody enabled auto-merge (squash) July 24, 2024 16:02
@apeabody apeabody merged commit 674f772 into terraform-google-modules:master Jul 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants