Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump kubelet config to ga + minor doc fixes #1994

Merged
merged 8 commits into from
Jul 19, 2024

Conversation

DrFaust92
Copy link
Contributor

No description provided.

@DrFaust92 DrFaust92 requested review from ericyz, gtsorbo and a team as code owners July 13, 2024 14:49
@DrFaust92 DrFaust92 changed the title bump kubelet config to ga + minor doc fixes feat: bump kubelet config to ga + minor doc fixes Jul 13, 2024
@DrFaust92 DrFaust92 marked this pull request as draft July 13, 2024 14:56
@DrFaust92 DrFaust92 force-pushed the kubelet_config-ga branch from fbd31d4 to e91fbf0 Compare July 13, 2024 15:03
@DrFaust92 DrFaust92 marked this pull request as ready for review July 13, 2024 15:11
@apeabody
Copy link
Collaborator

/gcbrun

@DrFaust92
Copy link
Contributor Author

apeabody need another comment here after the merge 😸

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

cluster.tf Show resolved Hide resolved
cluster.tf Show resolved Hide resolved
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @DrFaust92!

Please see the spacing nits above.

@DrFaust92 DrFaust92 requested a review from apeabody July 18, 2024 19:49
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody self-assigned this Jul 18, 2024
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @DrFaust92!

@apeabody apeabody merged commit 6bd1bc1 into terraform-google-modules:master Jul 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants