Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the value of output "identity_service_enabled" in beta modules #1982

Merged

Conversation

legal90
Copy link
Contributor

@legal90 legal90 commented Jun 21, 2024

It should return the value of "Identity Service" feature flag (local.cluster_identity_service_enabled), not "Pod Security Policy"(local.cluster_pod_security_policy_enabled)

It seems that there was a typo in the initial implementation of this feature in #1142.

Note: the local variable local.cluster_output_identity_service_enabled was already defined earlier, but it was deleted in #1598 because it wasn't used.

legal90 added 2 commits June 21, 2024 17:34
It should return the value of "Identity Service" feature flag, not "Pod Security Policy"
@legal90 legal90 requested review from ericyz, gtsorbo and a team as code owners June 21, 2024 15:39
@apeabody
Copy link
Collaborator

/gcbrun

List items should be accessed using square brackets (terraform_deprecated_index)
@legal90 legal90 force-pushed the fix-identity-service-output branch from 51f4545 to a0c99d9 Compare June 21, 2024 16:13
@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @legal90!

@apeabody apeabody merged commit a6210fc into terraform-google-modules:master Jun 22, 2024
4 checks passed
@legal90 legal90 deleted the fix-identity-service-output branch June 22, 2024 12:28
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants