-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: empty addons_config handling #1978
fix: empty addons_config handling #1978
Conversation
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @0Delta!
Please see the linter output for change.
dac779d
to
2a01483
Compare
I have fixed the points you pointed out, apologize for my bad format. |
From the linter:
|
Linter indicates the previous code, indicating that existing problems are not solved. |
Hi @0Delta - It appears the templates haven't been updated. Please see here for details: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/CONTRIBUTING.md#templating. Thanks! |
2a01483
to
6129e83
Compare
I finally found out what this repository was made up of. |
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @0Delta!
resolve #1716
Older clusters may have missing or missing values in
google_container_cluster.primary.addons_config
.The current code assumes that the value is sufficient and cannot resolve this.
This patch will reduce dirty hacks such as pulling and modifying this repo and importing.