Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TPG>=5.33)!: add secret manager add-on config to beta modules #1977

Merged

Conversation

legal90
Copy link
Contributor

@legal90 legal90 commented Jun 14, 2024

@legal90 legal90 requested review from ericyz, gtsorbo and a team as code owners June 14, 2024 09:34
Copy link

google-cla bot commented Jun 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@legal90 legal90 force-pushed the secret-manager-addon-for-gke branch from d55ef3c to 69e259a Compare June 14, 2024 09:41
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody changed the title feat: add secret manager add-on config to beta modules feat: add secret manager add-on config to beta modules Jun 17, 2024
@apeabody apeabody changed the title feat: add secret manager add-on config to beta modules feat: add secret manager add-on config to beta modules Jun 17, 2024
@apeabody
Copy link
Collaborator

Hi @legal90 - Can you please rebase?

@legal90 legal90 force-pushed the secret-manager-addon-for-gke branch from 69e259a to 9e2b355 Compare June 21, 2024 07:55
@legal90
Copy link
Contributor Author

legal90 commented Jun 21, 2024

@apeabody Sure! Rebased now

@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @legal90

Looks like this was added in v5.33.0, so please bump here: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/main/versions.tf.tmpl

@legal90 legal90 force-pushed the secret-manager-addon-for-gke branch from 9e2b355 to 01e87e7 Compare June 22, 2024 12:41
@legal90
Copy link
Contributor Author

legal90 commented Jun 22, 2024

@apeabody Thank you, good point! I bumped the min version now.

@apeabody apeabody changed the title feat: add secret manager add-on config to beta modules feat(TPG>=5.33)!: add secret manager add-on config to beta modules Jun 24, 2024
@apeabody
Copy link
Collaborator

/gcbrun

@legal90 legal90 force-pushed the secret-manager-addon-for-gke branch from 01e87e7 to 880f9d6 Compare June 26, 2024 07:39
@legal90 legal90 requested a review from apeabody June 26, 2024 07:43
@apeabody
Copy link
Collaborator

/gcbrun

@legal90 legal90 force-pushed the secret-manager-addon-for-gke branch from 880f9d6 to 9b00414 Compare June 27, 2024 14:19
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody self-assigned this Jun 28, 2024
@apeabody
Copy link
Collaborator

apeabody commented Jul 2, 2024

Hi @legal90 - Can you please merge in changes from the base branch. Thanks!

@legal90 legal90 force-pushed the secret-manager-addon-for-gke branch from 9b00414 to 5de7d85 Compare July 8, 2024 12:24
@legal90
Copy link
Contributor Author

legal90 commented Jul 8, 2024

@apeabody Sure! Rebased the branch now.

@apeabody
Copy link
Collaborator

apeabody commented Jul 8, 2024

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @legal90!

@apeabody
Copy link
Collaborator

apeabody commented Jul 8, 2024

Hi @legal90 - Can you please rebase, I'm not able to update your PRs. Once it is current, and the checks are green, it's ready to merge.

legal90 and others added 3 commits July 9, 2024 09:07
Update all beta modules. "make build"

Co-authored-by: Jayanta Dutta <[email protected]>
"secret_manager_config" argument was added in google provider v5.33.0
hashicorp/terraform-provider-google-beta#7448
@legal90 legal90 force-pushed the secret-manager-addon-for-gke branch from 5de7d85 to afe1930 Compare July 9, 2024 07:07
@apeabody
Copy link
Collaborator

apeabody commented Jul 9, 2024

/gcbrun

@apeabody apeabody enabled auto-merge (squash) July 9, 2024 17:55
@apeabody apeabody merged commit 5c58d89 into terraform-google-modules:master Jul 9, 2024
4 checks passed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@legal90 legal90 deleted the secret-manager-addon-for-gke branch August 14, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants