feat: Add enable_cilium_clusterwide_network_policy support #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SavvasM1
changed the title
apeabody
requested changes
Jun 12, 2024
There was a problem hiding this comment.
Thanks for the contribution @SavvasM1!
From the lint test:
Checking submodule's files generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/README.md /tmp/tmp.dH7WdF6rzI/workspace/README.md
164d163
< | enable\_cilium\_clusterwide\_network\_policy | Enable Cilium Cluster Wide Network Policies on the cluster | `bool` | `false` | no |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/private-cluster/README.md /tmp/tmp.dH7WdF6rzI/workspace/modules/private-cluster/README.md
171d170
< | enable\_cilium\_clusterwide\_network\_policy | Enable Cilium Cluster Wide Network Policies on the cluster | `bool` | `false` | no |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/private-cluster/variables.tf /tmp/tmp.dH7WdF6rzI/workspace/modules/private-cluster/variables.tf
541,546d540
< variable "enable_cilium_clusterwide_network_policy" {
< type = bool
< description = "Enable Cilium Cluster Wide Network Policies on the cluster"
< default = false
< }
<
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/private-cluster-update-variant/README.md /tmp/tmp.dH7WdF6rzI/workspace/modules/private-cluster-update-variant/README.md
193d192
< | enable\_cilium\_clusterwide\_network\_policy | Enable Cilium Cluster Wide Network Policies on the cluster | `bool` | `false` | no |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/private-cluster-update-variant/variables.tf /tmp/tmp.dH7WdF6rzI/workspace/modules/private-cluster-update-variant/variables.tf
541,546d540
< variable "enable_cilium_clusterwide_network_policy" {
< type = bool
< description = "Enable Cilium Cluster Wide Network Policies on the cluster"
< default = false
< }
<
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/variables.tf /tmp/tmp.dH7WdF6rzI/workspace/variables.tf
726,731d725
< variable "enable_cilium_clusterwide_network_policy" {
< type = bool
< description = "Enable Cilium Cluster Wide Network Policies on the cluster"
< default = false
< }
<
Error: submodule's files generation has not been run, please run the
'make build' command and commit changes
Heya @apeabody , thanks :) It should be OK now. Dockerized lint tests report as successful. |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
Hey @apeabody :). I've run |
|
/gcbrun |
|
confirmed |
Thanks for your help Andrew. |
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverage the existing configuration field on the google container cluster module to optionally declare usage of cilium clusterwide network policy CRDs