Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add enable_l4_ilb_subsetting for autopilot clusters #1969

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

kliu47
Copy link
Contributor

@kliu47 kliu47 commented Jun 6, 2024

setting already exists for other submodules. Adding functionality to autopilot submodule

@kliu47 kliu47 requested review from ericyz, gtsorbo and a team as code owners June 6, 2024 19:23
@kliu47 kliu47 changed the title Add ilb subsetting for autopilot clusters feat: Add enable_l4_ilb_subsetting for autopilot clusters Jun 6, 2024
@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @kliu47!

Can we confirm this is supported in Autopilot? GKE subsetting is disabled in Autopilot clusters.
https://cloud.google.com/kubernetes-engine/docs/how-to/internal-load-balancing#subsetting

At the very least we should enable in at least one autopilot example so it's exercised by the CI tests: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/examples/simple_autopilot_public/main.tf#L35

@kliu47
Copy link
Contributor Author

kliu47 commented Jun 20, 2024

@apeabody , Yes, this feature is supported in autopilot clusters, however the default behavior is to have it disabled
image

I've also gone ahead and added the setting to true in the public autopilot example:
https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/1969/files#diff-229618ff3e7246fb9ddf90bc00eea2b8f399b4412e8d42d7783d2ecf04bece48R51

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @kliu47!

@apeabody apeabody merged commit c48dc6e into terraform-google-modules:master Jun 20, 2024
4 checks passed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants