-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for logging_variant
in Autopilot clusters
#1962
feat: add support for logging_variant
in Autopilot clusters
#1962
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @abdel!
Can you please make your change in the source template as described here: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/CONTRIBUTING.md#templating. Thanks!
@apeabody Sorry for the late response, didn't get a notification for some reason! I made the changes to the Let me know if that looks OK! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @abdel!
/gcbrun |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @abdel!
…orm-google-modules#1962) Co-authored-by: Andrew Peabody <[email protected]>
Leverage the existing
logging_variant
[ref] option at a cluster-level ingoogle_container_cluster
module to (optionally) allow enablingMAX_THROUGHPUT
logging in Autopilot clusters.