Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set boot_disk_kms_key cluster wide and for cluster_autoscaling #1959

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

CPL-markus
Copy link
Contributor

Currently it seems impossible to set KMS keys (boot_disk_kms_key) for the cluster autoscaler, which leads to node-pools being created using Google Managed Keys for all boot disks. As this is supported by the resource google_container_cluster, it should also be supported in the module.

Additionally similar to service_account the KMS key should be possible to be set cluster-wide as well.

@CPL-markus CPL-markus requested review from ericyz, gtsorbo and a team as code owners May 28, 2024 17:08
Copy link

google-cla bot commented May 28, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @CPL-markus!

Please see the lint findings:

Working in ./modules/beta-autopilot-private-cluster ...
1 issue(s) found:

Warning: [Fixable] variable "boot_disk_kms_key" is declared but not used (terraform_unused_declarations)

  on variables.tf line 248:
 248: variable "boot_disk_kms_key" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.7.0/docs/rules/terraform_unused_declarations.md

tflint failed ./modules/beta-autopilot-private-cluster 
Working in ./modules/beta-autopilot-public-cluster ...
1 issue(s) found:

Warning: [Fixable] variable "boot_disk_kms_key" is declared but not used (terraform_unused_declarations)

  on variables.tf line 248:
 248: variable "boot_disk_kms_key" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.7.0/docs/rules/terraform_unused_declarations.md

tflint failed ./modules/beta-autopilot-public-cluster 

@CPL-markus CPL-markus requested a review from apeabody May 31, 2024 12:10
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody self-assigned this Jun 13, 2024
@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @CPL-markus!

Confirmed boot_disk_kms_key GA in TPG 5.25.0

@apeabody apeabody merged commit 654868e into terraform-google-modules:master Jun 13, 2024
4 checks passed
@CPL-markus
Copy link
Contributor Author

Thank you @apeabody for your support here!

CPL-markus added a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants