Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add secondary_boot_disks to node_pool configuration. #1946

Conversation

yorik
Copy link
Contributor

@yorik yorik commented May 15, 2024

PR adds secondary_boot_disks setting to cluster.tf in the node_config part.

@yorik yorik requested review from ericyz, gtsorbo and a team as code owners May 15, 2024 15:17
Copy link

google-cla bot commented May 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@yorik yorik force-pushed the ya-zkd-1636-container-preloading-for-prover-images-on-prover-node-pools branch from 6e1af1e to de7328f Compare May 16, 2024 15:06
@yorik yorik force-pushed the ya-zkd-1636-container-preloading-for-prover-images-on-prover-node-pools branch from de7328f to 4e9eaca Compare May 16, 2024 15:08
yorik added 2 commits May 16, 2024 17:13
@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @yorik!

Can you please rebase or ideally allow edits from maintainers.

@apeabody
Copy link
Collaborator

/gcbrun

@yorik
Copy link
Contributor Author

yorik commented May 17, 2024

Thanks for the contribution @yorik!

Can you please rebase or ideally allow edits from maintainers.

Sure, rebased.

Looks like I can't "Allow edits", probably because the repo was cloned into our organization and it blocked somehow.

@apeabody
Copy link
Collaborator

Thanks for the contribution @yorik!
Can you please rebase or ideally allow edits from maintainers.

Sure, rebased.

Looks like I can't "Allow edits", probably because the repo was cloned into our organization and it blocked somehow.

Thanks - Yeah, unfortunately that's needed for maintainers to rebase PRs.

@apeabody apeabody merged commit 11bae67 into terraform-google-modules:master May 17, 2024
4 checks passed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@yorik yorik deleted the ya-zkd-1636-container-preloading-for-prover-images-on-prover-node-pools branch August 9, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants