Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add local_ssd_ephemeral_count to default configuration #1944

Merged

Conversation

alvicsam
Copy link
Contributor

@alvicsam alvicsam commented May 15, 2024

PR adds ephemeral_storage_local_ssd_config setting to cluster.tf in the root of the module

@alvicsam alvicsam requested review from ericyz, gtsorbo and a team as code owners May 15, 2024 10:07
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @alvicsam!

Can you please make your change in the source template as described here: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/CONTRIBUTING.md#templating

@alvicsam
Copy link
Contributor Author

@apeabody thanks for the answer! I fixed the template and applied make. Could you please run CI again?

@apeabody apeabody self-assigned this May 21, 2024
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @alvicsam!

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody enabled auto-merge (squash) May 22, 2024 15:46
@apeabody apeabody merged commit 04ebd0c into terraform-google-modules:master May 22, 2024
4 checks passed
@alvicsam alvicsam deleted the as-add-ephemeral-ssd branch May 23, 2024 07:59
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants