Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add threads_per_core setting for node config in node pools #1942

Merged

Conversation

alvicsam
Copy link
Contributor

Fixes #1474

@alvicsam alvicsam requested review from ericyz, gtsorbo and a team as code owners May 14, 2024 15:02
Copy link

google-cla bot commented May 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @alvicsam!

From the linter: Error: The following tests have failed: check_generate_modules Can you run make generate_modules?

@alvicsam
Copy link
Contributor Author

@apeabody thanks for the answer! I applied make, could you please run the CI again?

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody self-assigned this May 21, 2024
@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @alvicsam!

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody merged commit e573ced into terraform-google-modules:master May 22, 2024
4 checks passed
@alvicsam alvicsam deleted the as-add-threads-per-core branch May 23, 2024 08:11
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include threads per core configuration for GKE clusters
2 participants