-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add threads_per_core setting for node config in node pools #1942
feat: Add threads_per_core setting for node config in node pools #1942
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @alvicsam!
From the linter: Error: The following tests have failed: check_generate_modules
Can you run make generate_modules
?
…rm-google-kubernetes-engine into as-add-threads-per-core
@apeabody thanks for the answer! I applied |
/gcbrun |
…rm-google-kubernetes-engine into as-add-threads-per-core
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @alvicsam!
/gcbrun |
/gcbrun |
Fixes #1474