Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add gpu_driver_version to recreate list + docs #1913

Merged
merged 5 commits into from
May 22, 2024

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Mar 25, 2024

fails to apply otherwise

closes #1906

@DrFaust92 DrFaust92 requested review from ericyz, gtsorbo and a team as code owners March 25, 2024 18:08
@DrFaust92 DrFaust92 changed the title add gpu_driver_version to recreate list fix: add gpu_driver_version to recreate list Mar 25, 2024
@DrFaust92 DrFaust92 changed the title fix: add gpu_driver_version to recreate list fix: add gpu_driver_version to recreate list + docs Apr 28, 2024
@apeabody
Copy link
Collaborator

/gcbrun

@DrFaust92
Copy link
Contributor Author

apeabody any issues with this? should i rebase?

@apeabody
Copy link
Collaborator

apeabody any issues with this? should i rebase?

The error probably isn't related to the change, re-running the tests on the rebase.

@DrFaust92
Copy link
Contributor Author

apeabody still fails, if there is anything i can do to help, lmk.

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

apeabody still fails, if there is anything i can do to help, lmk.

This time it needed a fresh gcbrun, we'll see how it comes back.

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @DrFaust92!

@apeabody apeabody merged commit 12cf40f into terraform-google-modules:master May 22, 2024
4 checks passed
@DrFaust92 DrFaust92 deleted the gpu branch May 24, 2024 05:14
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing node_pools variable in beta-private-cluster documentation
2 participants