Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option image_type in cluster_autoscaling block #1905

Merged
merged 3 commits into from
May 20, 2024

Conversation

endrec
Copy link
Contributor

@endrec endrec commented Mar 18, 2024

Fixes #1904

@endrec endrec requested review from ericyz, gtsorbo and a team as code owners March 18, 2024 17:18
Copy link

google-cla bot commented Mar 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@endrec endrec changed the title Add option image_type in cluster_autoscaling block feat: Add option image_type in cluster_autoscaling block Mar 18, 2024
@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @endrec!

Can you please add image_type to the cluster_autoscaling variable so it is included in the generated documentation: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/main/variables.tf.tmpl#L244

@endrec endrec requested a review from apeabody May 17, 2024 15:45
@apeabody
Copy link
Collaborator

Thanks @endrec! - Can you please (also) make your change to the template: autogen/main/variables.tf.tmpl and then make build.

@endrec
Copy link
Contributor Author

endrec commented May 20, 2024

@apeabody Done. :)

@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @endrec!

@apeabody apeabody merged commit 2272164 into terraform-google-modules:master May 20, 2024
4 checks passed
@endrec endrec deleted the nap-image-type branch May 20, 2024 23:06
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Option for specifying image_type in auto_provisioning_defaults
2 participants