-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add option image_type in cluster_autoscaling block #1905
feat: Add option image_type in cluster_autoscaling block #1905
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @endrec!
Can you please add image_type
to the cluster_autoscaling
variable so it is included in the generated documentation: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/main/variables.tf.tmpl#L244
Thanks @endrec! - Can you please (also) make your change to the template: |
@apeabody Done. :) |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @endrec!
Fixes #1904