Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add direct fleet registration #1878

Merged
merged 1 commit into from
Feb 26, 2024
Merged

feat: add direct fleet registration #1878

merged 1 commit into from
Feb 26, 2024

Conversation

apeabody
Copy link
Collaborator

No description provided.

@apeabody apeabody changed the title feat: add fleet block feat: add direct fleet registration Feb 15, 2024
@apeabody
Copy link
Collaborator Author

need to add test coverage

@apeabody apeabody force-pushed the ap/borninfleet branch 7 times, most recently from a22ccb5 to 13462b2 Compare February 16, 2024 15:46
@apeabody apeabody marked this pull request as ready for review February 21, 2024 23:12
@apeabody apeabody requested review from ericyz and a team as code owners February 21, 2024 23:12
@apeabody apeabody enabled auto-merge (squash) February 22, 2024 00:04
bharathkkb
bharathkkb approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @apeabody, minor question

modules/private-cluster/variables.tf Outdated Show resolved Hide resolved
@apeabody apeabody disabled auto-merge February 23, 2024 17:00
@apeabody apeabody requested a review from gtsorbo as a code owner February 23, 2024 22:13
@apeabody apeabody force-pushed the ap/borninfleet branch 2 times, most recently from 89d58bc to b70ca1a Compare February 23, 2024 22:58
@apeabody apeabody merged commit 6b267bd into master Feb 26, 2024
8 checks passed
@apeabody apeabody deleted the ap/borninfleet branch February 26, 2024 18:19
@release-please release-please bot mentioned this pull request Feb 23, 2024
Merged
fl0-m pushed a commit to fl0-m/terraform-google-kubernetes-engine that referenced this pull request Mar 23, 2024
@apeabody @fl0-m
feat: add direct fleet registration option (terraform-google-modules#…
0c0382c 
…1878)
@yorik yorik mentioned this pull request May 14, 2024
Closed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@apeabody
feat: add direct fleet registration option (terraform-google-modules#…
8a76d86 
…1878)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

@gtsorbo gtsorbo Awaiting requested review from gtsorbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apeabody @bharathkkb