Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(safer-clusters): add components selection for monitoring #1851

Merged

Conversation

bergemalm
Copy link
Contributor

This adds the possibility to configure what monitoring components should be enabled for the safer cluster variants.

@bergemalm bergemalm requested review from ericyz and a team as code owners January 22, 2024 07:32
Copy link

google-cla bot commented Jan 22, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@foosinn
Copy link
Contributor

foosinn commented Mar 15, 2024

Hey, also would like to see this merged. This currently causes some issues with our monitoring

@foosinn
Copy link
Contributor

foosinn commented Mar 28, 2024

@gtsorbo is there maybe a way to get this moving? We really would like to avoid forking the repository

@bergemalm bergemalm requested a review from gtsorbo as a code owner March 28, 2024 16:16
@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @bergemalm!

One note on the description string as the module currently requires TPG 5.9.0 and then this should be good to merge. Also might want to mark this as a "feat" rather than "fix".

autogen/safer-cluster/variables.tf.tmpl Outdated Show resolved Hide resolved
modules/safer-cluster-update-variant/README.md Outdated Show resolved Hide resolved
modules/safer-cluster-update-variant/variables.tf Outdated Show resolved Hide resolved
modules/safer-cluster/README.md Outdated Show resolved Hide resolved
modules/safer-cluster/variables.tf Outdated Show resolved Hide resolved
@bergemalm bergemalm force-pushed the fix/prom-components branch from c774fe8 to 856f228 Compare April 1, 2024 20:23
@bergemalm bergemalm changed the title fix(safer-clusters): add components selection for monitoring feat(safer-clusters): add components selection for monitoring Apr 1, 2024
@apeabody
Copy link
Collaborator

apeabody commented Apr 1, 2024

/gcbrun

@apeabody apeabody merged commit 15b472f into terraform-google-modules:master Apr 1, 2024
4 checks passed
@foosinn
Copy link
Contributor

foosinn commented Apr 2, 2024

Thanks so much :)

CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants