-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(safer-clusters): add components selection for monitoring #1851
feat(safer-clusters): add components selection for monitoring #1851
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hey, also would like to see this merged. This currently causes some issues with our monitoring |
@gtsorbo is there maybe a way to get this moving? We really would like to avoid forking the repository |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @bergemalm!
One note on the description string as the module currently requires TPG 5.9.0 and then this should be good to merge. Also might want to mark this as a "feat" rather than "fix".
c774fe8
to
856f228
Compare
/gcbrun |
Thanks so much :) |
This adds the possibility to configure what monitoring components should be enabled for the safer cluster variants.