-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TPG>=5.9)!: cluster autoscaling profile is GA #1839
feat(TPG>=5.9)!: cluster autoscaling profile is GA #1839
Conversation
5ee09a3
to
606fcd2
Compare
@apeabody could you review maybe? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @florianmutter!
We'll also need to bump the minimum provider in https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/main/versions.tf.tmp
Ref: https://github.com/hashicorp/terraform-provider-google/releases/tag/v5.9.0
Thank you for the review. I updated the required provider version for the regular provider. Should the beta provider be aligned? I don't think it is necessary but might prevent confusion on why the version requirements differ. |
Yeah, while it's not technically required, I would recommend we keep them version matched to minimize confusion. |
Updated both versions |
@apeabody ping :) |
/gcbrun |
re-trigger
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @florianmutter!
GKE autoscaling profile is GA now
Closes #1820