Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TPG>=5.9)!: cluster autoscaling profile is GA #1839

Merged
merged 7 commits into from
Jan 26, 2024

Conversation

florianmutter
Copy link
Contributor

GKE autoscaling profile is GA now

Closes #1820

@florianmutter
Copy link
Contributor Author

@apeabody could you review maybe?

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@florianmutter
Copy link
Contributor Author

florianmutter commented Jan 19, 2024

Thank you for the review. I updated the required provider version for the regular provider. Should the beta provider be aligned? I don't think it is necessary but might prevent confusion on why the version requirements differ.

@apeabody
Copy link
Collaborator

Thank you for the review. I updated the required provider version for the regular provider. Should the beta provider be aligned? I don't think it is necessary but might prevent confusion on why the version requirements differ.

Yeah, while it's not technically required, I would recommend we keep them version matched to minimize confusion.

@florianmutter
Copy link
Contributor Author

Updated both versions

@florianmutter
Copy link
Contributor Author

@apeabody ping :)

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

re-trigger

STDERR: Error: Provider produced inconsistent result after apply

When applying changes to
module.example.module.workload_identity.google_service_account.cluster_service_account[0],
provider "provider[\"registry.terraform.io/hashicorp/google\"]" produced an
unexpected new value: Root object was present, but now absent.

This is a bug in the provider, which should be reported in the provider's own
issue tracker.
---- End output 

@apeabody apeabody self-assigned this Jan 25, 2024
@apeabody apeabody changed the title feat: cluster autoscaling profile is GA feat(TPG>=5.9)!: cluster autoscaling profile is GA Jan 26, 2024
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @florianmutter!

@apeabody apeabody merged commit 495623e into terraform-google-modules:master Jan 26, 2024
4 checks passed
@florianmutter florianmutter deleted the patch-1 branch January 27, 2024 17:30
@florianmutter
Copy link
Contributor Author

florianmutter commented Jan 31, 2024

@apeabody any chance we can get a new release of the module? Seems like an ok list of changes for a new release to me :D #1794

CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add autoscaling profiles to non beta submodules
2 participants