Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dual stack (IPV4_IPV6) support #1818

Merged
merged 17 commits into from
Jan 3, 2024
Merged

feat: dual stack (IPV4_IPV6) support #1818

merged 17 commits into from
Jan 3, 2024

Conversation

ghabian
Copy link
Contributor

@ghabian ghabian commented Dec 14, 2023

making a separate PR to attempt to fix issues with #1672 adding support for dual stack GKE clusters (by @jmymy )
fixes:
#1656
#1602

@ghabian ghabian requested review from ericyz and a team as code owners December 14, 2023 21:53
@ghabian ghabian marked this pull request as draft December 14, 2023 22:10
@bharathkkb
Copy link
Member

/gcbrun

@ghabian ghabian changed the title Add dual stack beta feat: dual stack (IPV4_IPV6) support Dec 15, 2023
@ghabian
Copy link
Contributor Author

ghabian commented Dec 15, 2023

/gcbrun

1 similar comment
@bharathkkb
Copy link
Member

/gcbrun

@ghabian
Copy link
Contributor Author

ghabian commented Dec 16, 2023

/gcbrun

@bharathkkb
Copy link
Member

/gcbrun

@ghabian
Copy link
Contributor Author

ghabian commented Dec 18, 2023

note: The PR is in draft I'm just making sure the new URL for the ACM policy bundle is correct (cc: @apeabody ). otherwise the code should be ready for review (if one is needed)

@apeabody
Copy link
Collaborator

/gcbrun

@ghabian ghabian marked this pull request as ready for review December 19, 2023 00:00
@ghabian ghabian mentioned this pull request Dec 19, 2023
Closed
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody requested a review from bharathkkb December 28, 2023 16:42
apeabody
apeabody approved these changes Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @ghabian!

@apeabody apeabody merged commit d6cb390 into terraform-google-modules:master Jan 3, 2024
4 checks passed
@release-please release-please bot mentioned this pull request Jan 3, 2024
Merged
@ghabian ghabian deleted the add-dual-stack-beta branch February 1, 2024 23:14
@yorik yorik mentioned this pull request May 14, 2024
Closed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@ghabian @jmymy
@bharathkkb @apeabody
feat: dual stack (IPV4_IPV6) support (terraform-google-modules#1818)
39ce79b 
Co-authored-by: Jonathan Meyers <[email protected]>
Co-authored-by: Jonathan Meyers <[email protected]>
Co-authored-by: Bharath KKB <[email protected]>
Co-authored-by: Ghaleb <[email protected]>
Co-authored-by: Ghaleb Al-Habian <[email protected]>
Co-authored-by: Andrew Peabody <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ghabian @bharathkkb @apeabody @jmymy