Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for gpu_driver_installation_config on nodepool #1767

Merged
merged 7 commits into from
Oct 27, 2023
Merged

feat: add support for gpu_driver_installation_config on nodepool #1767

merged 7 commits into from
Oct 27, 2023

Conversation

umeshkumhar
Copy link
Contributor

  • Updated guest_accelerator to add gpu driver installation

@umeshkumhar umeshkumhar requested review from Jberlinsky, ericyz and a team as code owners October 11, 2023 19:38
@bharathkkb
Copy link
Member

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Oct 15, 2023

Please review the logs below
gpu_driver_version = lookup(each.value, "gpu_driver_version", "")

  •        gpu_driver_version = lookup(each.value, "gpu_driver_version", "")

@umeshkumhar
Copy link
Contributor Author

@ericyz @bharathkkb Updated the fix.

@ericyz
Copy link
Collaborator

ericyz commented Oct 23, 2023

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Oct 23, 2023 •
edited
Loading

@umeshkumhar - please find error logs below

--- old/cluster.tf
+++ new/cluster.tf
@@ -528,11 +528,11 @@
type = lookup(each.value, "accelerator_type", "")
count = lookup(each.value, "accelerator_count", 0)
gpu_partition_size = lookup(each.value, "gpu_partition_size", null)

  •    dynamic "gpu_driver_installation_config" {
     for_each = lookup(each.value, "gpu_driver_version", "") != "" ? [1] : []
     content {

  •        gpu_driver_version   = lookup(each.value, "gpu_driver_version", "")

  •        gpu_driver_version = lookup(each.value, "gpu_driver_version", "")
     }
   }
 }

@@ -727,7 +727,7 @@
dynamic "gpu_driver_installation_config" {
for_each = lookup(each.value, "gpu_driver_version", "") != "" ? [1] : []
content {

  •        gpu_driver_version   = lookup(each.value, "gpu_driver_version", "")

  •        gpu_driver_version = lookup(each.value, "gpu_driver_version", "")
     }
   }
 }

Error: terraform fmt failed with exit code 3
Check the output for diffs and correct using terraform fmt


modules/beta-private-cluster-update-variant/cluster.tf
--- old/modules/beta-private-cluster-update-variant/cluster.tf
+++ new/modules/beta-private-cluster-update-variant/cluster.tf
@@ -739,7 +739,7 @@
dynamic "gpu_driver_installation_config" {
for_each = lookup(each.value, "gpu_driver_version", "") != "" ? [1] : []
content {

  •        gpu_driver_version   = lookup(each.value, "gpu_driver_version", "")

  •        gpu_driver_version = lookup(each.value, "gpu_driver_version", "")
     }
   }
 }

@@ -974,7 +974,7 @@
dynamic "gpu_driver_installation_config" {
for_each = lookup(each.value, "gpu_driver_version", "") != "" ? [1] : []
content {

  •        gpu_driver_version   = lookup(each.value, "gpu_driver_version", "")

  •        gpu_driver_version = lookup(each.value, "gpu_driver_version", "")
     }
   }

Error: terraform fmt failed with exit code 3
Check the output for diffs and correct using terraform fmt


}
modules/beta-public-cluster/cluster.tf
--- old/modules/beta-public-cluster/cluster.tf
+++ new/modules/beta-public-cluster/cluster.tf
@@ -626,7 +626,7 @@
dynamic "gpu_driver_installation_config" {
for_each = lookup(each.value, "gpu_driver_version", "") != "" ? [1] : []
content {

  •        gpu_driver_version   = lookup(each.value, "gpu_driver_version", "")

  •        gpu_driver_version = lookup(each.value, "gpu_driver_version", "")
     }
   }
 }

@@ -860,7 +860,7 @@
dynamic "gpu_driver_installation_config" {
for_each = lookup(each.value, "gpu_driver_version", "") != "" ? [1] : []
content {

  •        gpu_driver_version   = lookup(each.value, "gpu_driver_version", "")

  •        gpu_driver_version = lookup(each.value, "gpu_driver_version", "")
     }
   }
 }

Error: terraform fmt failed with exit code 3
Check the output for diffs and correct using terraform fmt


modules/private-cluster/cluster.tf
--- old/modules/private-cluster/cluster.tf
+++ new/modules/private-cluster/cluster.tf
@@ -551,7 +551,7 @@
dynamic "gpu_driver_installation_config" {
for_each = lookup(each.value, "gpu_driver_version", "") != "" ? [1] : []
content {

  •        gpu_driver_version   = lookup(each.value, "gpu_driver_version", "")

  •        gpu_driver_version = lookup(each.value, "gpu_driver_version", "")
     }
   }
 }

@@ -746,7 +746,7 @@
dynamic "gpu_driver_installation_config" {
for_each = lookup(each.value, "gpu_driver_version", "") != "" ? [1] : []
content {

  •        gpu_driver_version   = lookup(each.value, "gpu_driver_version", "")

  •        gpu_driver_version = lookup(each.value, "gpu_driver_version", "")
     }
   }
 }

Error: terraform fmt failed with exit code 3

@umeshkumhar
Copy link
Contributor Author

umeshkumhar commented Oct 26, 2023 •
edited
Loading

@ericyz I hope this should fix lints now, can we rerun the testcases again?

@apeabody
Copy link
Collaborator

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Oct 27, 2023

Notes for myself. feature added in v4.75.0

ericyz
ericyz approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@ericyz ericyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericyz ericyz merged commit f43a241 into terraform-google-modules:master Oct 27, 2023
4 checks passed
@release-please release-please bot mentioned this pull request Oct 27, 2023
Merged
@Vhaos Vhaos mentioned this pull request Nov 2, 2023
Closed
@michaellzc michaellzc mentioned this pull request Nov 23, 2023
Merged
@yorik yorik mentioned this pull request May 14, 2024
Closed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@umeshkumhar @apeabody
feat: add support for gpu_driver_installation_config on nodepool (ter…
73801ab 
…raform-google-modules#1767)

Co-authored-by: Andrew Peabody <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericyz ericyz ericyz approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@umeshkumhar @bharathkkb @ericyz @apeabody