Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TPGv5)!: update to TPG v5 #1761

Merged
merged 19 commits into from
Oct 31, 2023
Merged

fix(TPGv5)!: update to TPG v5 #1761

merged 19 commits into from
Oct 31, 2023

Conversation

g-awmalik
Copy link
Contributor

No description provided.

@g-awmalik g-awmalik requested review from Jberlinsky, ericyz and a team as code owners October 6, 2023 23:16
@apeabody apeabody self-assigned this Oct 9, 2023
@apeabody apeabody changed the title chore: upgraded versions.tf to include minor bumps from tpg v5 fix: upgraded versions.tf to include minor bumps from tpg v5 Oct 9, 2023
@apeabody
Copy link
Collaborator

@apeabody apeabody force-pushed the chore/tpg-bump branch 2 times, most recently from e5674af to 3db7560 Compare October 10, 2023 20:49
@apeabody
Copy link
Collaborator

"container: added deletion_protection to google_container_cluster which is enabled to true by default. When enabled, this field prevents Terraform from deleting the resource. (hashicorp/terraform-provider-google#16013)"

@g-awmalik
Copy link
Contributor Author

/gcbrun

@apeabody
Copy link
Collaborator

FYI @g-awmalik - This is going to need updates for the breaking change to deletion_protection.

@apeabody apeabody changed the title fix: upgraded versions.tf to include minor bumps from tpg v5 fix!: upgraded versions.tf to include minor bumps from tpg v5 Oct 27, 2023
@apeabody apeabody changed the title fix!: upgraded versions.tf to include minor bumps from tpg v5 fix(tpg5)!: upgraded versions.tf to include minor bumps from tpg v5 Oct 27, 2023
@apeabody
Copy link
Collaborator

apeabody commented Oct 27, 2023

FYI @g-awmalik - This is going to need updates for the breaking change to deletion_protection.

Unfortunately deletion_protection was added new in tpg v5.0.0, so we'll need to bump the min and update all dependency modules as well. I'm working on terraform-google-network which is used several CI samples.

@apeabody
Copy link
Collaborator

FYI @g-awmalik - This is going to need updates for the breaking change to deletion_protection.

Unfortunately deletion_protection was added new in tpg v5.0.0, so we'll need to bump the min and update all dependency modules as well. I'm working on terraform-google-network which is used several CI samples.

Also need update to terraform-google-modules/bastion-host/google for examples/safer_cluster_iap_bastion

@apeabody
Copy link
Collaborator

apeabody commented Oct 27, 2023

FYI @g-awmalik - This is going to need updates for the breaking change to deletion_protection.

Unfortunately deletion_protection was added new in tpg v5.0.0, so we'll need to bump the min and update all dependency modules as well. I'm working on terraform-google-network which is used several CI samples.

Also need update to terraform-google-modules/bastion-host/google for examples/safer_cluster_iap_bastion

Need to update terraform-google-vm for terraform-google-modules/bastion-host/google

@apeabody
Copy link
Collaborator

Needs to be updated for tpg v5 https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/chore/tpg-bump/examples/safer_cluster_iap_bastion/network.tf#L50

@g-awmalik
Copy link
Contributor Author

@apeabody - looks like this is good to go finally.

@apeabody apeabody changed the title fix(tpg5)!: upgraded versions.tf to include minor bumps from tpg v5 fix(TPGv5)!: update to TPG v5 Oct 31, 2023
@apeabody
Copy link
Collaborator

@apeabody - looks like this is good to go finally.

Hi @g-awmalik - I just added some final upgrade guide entries: upgrading_to_v29.0.md. Given the volume of changes can you PTAL at the entire PR, and once the CI is green we should be ready to merge. :)

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We should get a second Review on this change.

Copy link
Contributor Author

@g-awmalik g-awmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding the upgrade docs.

@apeabody apeabody merged commit 455a93c into master Oct 31, 2023
8 checks passed
@apeabody apeabody deleted the chore/tpg-bump branch October 31, 2023 16:28
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants