Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add security posture #1750

Merged

Conversation

mmorejon
Copy link
Contributor

@mmorejon mmorejon commented Sep 28, 2023

Adds support for security posture configuration - https://cloud.google.com/kubernetes-engine/docs/concepts/about-security-posture-dashboard

Duplicated: #1719 #1694

@mmorejon mmorejon requested review from Jberlinsky, ericyz and a team as code owners September 28, 2023 13:00
@mmorejon mmorejon force-pushed the add-security-posture branch from bca5096 to 77787f2 Compare September 28, 2023 21:20
@mmorejon
Copy link
Contributor Author

mmorejon commented Oct 6, 2023

Hi! @Jberlinsky , @ericyz !
Do you need something else from my side for the review?

@mmorejon mmorejon force-pushed the add-security-posture branch from 77787f2 to 9e21d25 Compare October 10, 2023 21:52
@cmreddyv
Copy link

please someone review and fix it.

@mmorejon mmorejon force-pushed the add-security-posture branch from 9e21d25 to 55be990 Compare October 11, 2023 07:22
Signed-off-by: Manuel Morejon <[email protected]>
@mmorejon mmorejon force-pushed the add-security-posture branch from 55be990 to ef8ce4f Compare October 17, 2023 19:35
@mmorejon
Copy link
Contributor Author

@apeabody , could you run the tests?

@apeabody
Copy link
Collaborator

/gcbrun

@cmreddyv
Copy link

please let us know, when this will be merged to master ?

@ebeltramo96
Copy link

any news?

@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @mmorejon!

@apeabody apeabody merged commit 5d959a6 into terraform-google-modules:master Oct 27, 2023
4 checks passed
@mmorejon mmorejon deleted the add-security-posture branch October 27, 2023 22:11
@cmreddyv
Copy link

Thank you @apeabody for merging and @mmorejon for the PR.

Please let me know, by when this will be available for Terraform Tag release. current 28 version does not have the security posture config

@apeabody
Copy link
Collaborator

Thank you @apeabody for merging and @mmorejon for the PR.

Please let me know, by when this will be available for Terraform Tag release. current 28 version does not have the security posture config

Hi @cmreddyv - I should be included when v29.0.0 is released (#1746), if needed you can also source the repo head directly in the meantime.

@DrFaust92
Copy link
Contributor

Closes #1743

CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants