Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: make promethus configurable #1715

Merged
merged 18 commits into from
Sep 26, 2023

Conversation

ericyz
Copy link
Collaborator

@ericyz ericyz commented Aug 22, 2023

Fix Issue: #1706

Breaking Change

  • Change dynamic block to static and the default value of enable_prometheus changes

@ericyz ericyz force-pushed the fix/promethus-enable branch from 444d911 to 48b2be7 Compare August 22, 2023 23:39
@ericyz ericyz force-pushed the fix/promethus-enable branch 3 times, most recently from c3d0e9d to 7284d55 Compare August 23, 2023 00:43
@ericyz
Copy link
Collaborator Author

ericyz commented Aug 23, 2023

/gcbrun

2 similar comments
@ericyz
Copy link
Collaborator Author

ericyz commented Aug 24, 2023

/gcbrun

@ericyz
Copy link
Collaborator Author

ericyz commented Aug 24, 2023

/gcbrun

@ericyz ericyz force-pushed the fix/promethus-enable branch from 9f1d025 to b734db5 Compare August 25, 2023 03:40
@ericyz
Copy link
Collaborator Author

ericyz commented Aug 28, 2023

/gcbrun

@ericyz
Copy link
Collaborator Author

ericyz commented Aug 29, 2023

/gcbrun

4 similar comments
@ericyz
Copy link
Collaborator Author

ericyz commented Aug 30, 2023

/gcbrun

@ericyz
Copy link
Collaborator Author

ericyz commented Sep 4, 2023

/gcbrun

@ericyz
Copy link
Collaborator Author

ericyz commented Sep 4, 2023

/gcbrun

@ericyz
Copy link
Collaborator Author

ericyz commented Sep 6, 2023

/gcbrun

@apeabody apeabody self-assigned this Sep 11, 2023
@ericyz
Copy link
Collaborator Author

ericyz commented Sep 20, 2023

/gcbrun

@ericyz
Copy link
Collaborator Author

ericyz commented Sep 20, 2023

Hi @apeabody , could you please help to review the change? It passed the all checks.

@ericyz ericyz changed the title fix: make promethus configurable feat!: make promethus configurable Sep 21, 2023
@ericyz
Copy link
Collaborator Author

ericyz commented Sep 22, 2023

/gcbrun

1 similar comment
@ericyz
Copy link
Collaborator Author

ericyz commented Sep 22, 2023

/gcbrun

@ericyz
Copy link
Collaborator Author

ericyz commented Sep 25, 2023

/gcbrun

@ericyz
Copy link
Collaborator Author

ericyz commented Sep 25, 2023

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @ericyz!

@apeabody apeabody merged commit ae26016 into terraform-google-modules:master Sep 26, 2023
4 checks passed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants