feat: mesh_certificates support #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgvdiscord
changed the title
bgvdiscord
changed the title
bgvdiscord
force-pushed
the
feat/safer-cluster-mesh-certificates
branch
2 times, most recently
from
e2b2fcb to
6a5093b
Compare
|
Hi @bgvdiscord , thank you for your contribution. Please help to resolve the conflicts and I will help to review this |
bgvdiscord
force-pushed
the
feat/safer-cluster-mesh-certificates
branch
from
6a5093b to
55e447d
Compare
bgvdiscord
changed the title
@ericyz : conflicts are resolved. Thanks! |
somethingnew2-0
approved these changes
Sep 1, 2023
g-awmalik
reviewed
Sep 6, 2023
|
/gcbrun |
g-awmalik
reviewed
Sep 6, 2023
| @@ -185,6 +185,9 @@ module "gke" { | |||
| // We enable Workload Identity by default. | |||
| identity_namespace = "${var.project_id}.svc.id.goog" | |||
|
|
|||
| // Enabling mesh certificates requires Workload Identity | |||
| enable_mesh_certificates = var.enable_mesh_certificates | |||
There was a problem hiding this comment.
Please wrap this in {% if autopilot_cluster != true %} so it doesn't render for autopilot clusters.
bgvdiscord
force-pushed
the
feat/safer-cluster-mesh-certificates
branch
from
91145cd to
ba8641c
Compare
bgvdiscord
force-pushed
the
feat/safer-cluster-mesh-certificates
branch
from
ba8641c to
00878e5
Compare
bgvdiscord
commented
Sep 7, 2023
| @@ -219,6 +219,12 @@ locals { | |||
| cluster_workload_identity_config = ! local.workload_identity_enabled ? [] : var.identity_namespace == "enabled" ? [{ | |||
| workload_pool = "${var.project_id}.svc.id.goog" }] : [{ workload_pool = var.identity_namespace | |||
| }] | |||
| {% if autopilot_cluster != true %} | |||
There was a problem hiding this comment.
Fixed: cluster_mesh_certificates_config no longer in autopilot clusters.
bgvdiscord
commented
Sep 7, 2023
| @@ -219,6 +219,12 @@ locals { | |||
| cluster_workload_identity_config = ! local.workload_identity_enabled ? [] : var.identity_namespace == "enabled" ? [{ | |||
| workload_pool = "${var.project_id}.svc.id.goog" }] : [{ workload_pool = var.identity_namespace | |||
| }] | |||
| {% if autopilot_cluster != true %} | |||
| cluster_mesh_certificates_config = local.workload_identity_enabled ? [{ | |||
There was a problem hiding this comment.
Applied readability suggestion - thanks!
|
@g-awmalik those changes are made; thanks! |
|
/gcbrun |
|
Thanks for the updates @bgvdiscord. There still seem to be a few references in the autopilot modules. Please take a look at the lint check and resolve them. |
bgvdiscord
commented
Sep 11, 2023
| @@ -170,6 +170,17 @@ output "identity_namespace" { | |||
| google_container_cluster.primary | |||
| ] | |||
| } | |||
|
|
|||
| {% if autopilot_cluster != true %} | |||
There was a problem hiding this comment.
Wrapped to fix lint
|
/gcbrun |
g-awmalik
approved these changes
Sep 11, 2023
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements feature request from #1691 (quoted below) to add
enable_mesh_certificatesconfiguration option, including to safer-cluster.Defaults to
false/ not enabled, which is the default behavior for clusters without it set. Not sure whether to call this a breaking change due to overwriting if value was set totruewith another module or gcloud command.Happy to take feedback.