Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support configuring ACM git service account email #1685

Merged
merged 2 commits into from
Sep 13, 2023
Merged

feat: support configuring ACM git service account email #1685

merged 2 commits into from
Sep 13, 2023

Conversation

ferrarimarco
Copy link
Contributor

This PR exposes the gcp_service_account_email configuration setting. Without this, users cannot configure a Service Account to access the ACM Git repository.

@ferrarimarco ferrarimarco requested review from a team, Jberlinsky and ericyz as code owners July 3, 2023 11:13
@ferrarimarco ferrarimarco changed the title (feat): Support configuring ACM service account email (feat): support configuring ACM service account email Jul 3, 2023
@ferrarimarco ferrarimarco changed the title (feat): support configuring ACM service account email feat: support configuring ACM service account email Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Sep 1, 2023
@ferrarimarco
Copy link
Contributor Author

Not stale :)

@github-actions github-actions bot removed the Stale label Sep 2, 2023
@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @ferrarimarco!

@apeabody apeabody changed the title feat: support configuring ACM service account email feat: support configuring ACM git service account email Sep 13, 2023
@apeabody apeabody merged commit 426f06f into terraform-google-modules:master Sep 13, 2023
@ferrarimarco ferrarimarco deleted the acm-gcp-account-email branch September 14, 2023 06:19
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants