Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: policy bundles now use idx as resource name (bundles will be re-applied) #1657

Merged
merged 2 commits into from
Jun 2, 2023

Conversation

apeabody
Copy link
Collaborator

@apeabody apeabody commented Jun 1, 2023

The module name is used by the gcloud module in paths, so long uls or special characters could cause issues depending on the local filesystem.

BEGIN_COMMIT_OVERRIDE
fix: extend acm wait when policy bundles are present (#1657)
END_COMMIT_OVERRIDE

@apeabody apeabody force-pushed the ap-patch-35k branch 2 times, most recently from 0842b86 to 606380a Compare June 1, 2023 18:11
@apeabody apeabody marked this pull request as ready for review June 2, 2023 00:04
@apeabody apeabody requested review from a team, Jberlinsky and ericyz as code owners June 2, 2023 00:04
@apeabody apeabody requested review from bharathkkb and g-awmalik June 2, 2023 00:05
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @apeabody, one question regarding upgrade

modules/acm/policy_bundles.tf Show resolved Hide resolved
@apeabody apeabody changed the title fix: Use index as name to avoid long url or special filesystem chars fix: acm policy use idx (results in a reapply) Jun 2, 2023
@apeabody apeabody changed the title fix: acm policy use idx (results in a reapply) fix: policy bundle use idx for name (bundles will be re-applied to cluster) Jun 2, 2023
@apeabody apeabody changed the title fix: policy bundle use idx for name (bundles will be re-applied to cluster) fix: policy bundles now use idx as resource name (bundles will be re-applied to cluster) Jun 2, 2023
@apeabody apeabody changed the title fix: policy bundles now use idx as resource name (bundles will be re-applied to cluster) fix: policy bundles now use idx as resource name (bundles will be re-applied) Jun 2, 2023
@apeabody apeabody merged commit e51804e into master Jun 2, 2023
@apeabody apeabody deleted the ap-patch-35k branch June 2, 2023 16:01
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants