Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid TPG 4.65.0 and 4.65.1 #1637

Merged
merged 1 commit into from
May 16, 2023
Merged

fix: avoid TPG 4.65.0 and 4.65.1 #1637

merged 1 commit into from
May 16, 2023

Conversation

apeabody
Copy link
Collaborator

@apeabody apeabody commented May 16, 2023

@apeabody apeabody requested review from a team, Jberlinsky and ericyz as code owners May 16, 2023 16:00
@apeabody apeabody changed the title fix: prevent TPG 4.65.0 and 4.65.1 fix: pin TPG <4.65.0 May 16, 2023
@apeabody apeabody changed the title fix: pin TPG <4.65.0 fix: avoid TPG 4.65.0 and 4.65.1 May 16, 2023
@apeabody apeabody merged commit ea3e374 into master May 16, 2023
@apeabody apeabody deleted the ap-patch-tpg branch May 16, 2023 19:44
apeabody added a commit that referenced this pull request May 22, 2023
@wyardley
Copy link
Contributor

wyardley commented May 22, 2023

q: maybe I'm parsing this wrong, but doesn't <4.65.0 already prevent 4.65.0 and 4.65.1 in version = ">= 4.51.0, < 4.65.0, !=4.65.0, !=4.65.1" (but also disallow anything > 4.65.0, which I think is not intended?)

Doesn't this make 4.65.2, for example, invalid? I'm getting an error with it.

│ Error: Failed to query available provider packages
│ 
│ Could not retrieve the list of available versions for provider hashicorp/google: no
│ available releases match the given constraints >= 4.18.0, >= 4.51.0, < 4.65.0, !=
│ 4.65.0, != 4.65.1, 4.65.2

@apeabody
Copy link
Collaborator Author

Hi @wyardley - Thanks for reaching out!

We needed to avoid usage of TPG 4.65.0 and 4.65.1, please use one of the following which includes #1640 and will enable 4.65.2, etc:

@wyardley
Copy link
Contributor

wyardley commented May 22, 2023

@apeabody it's in trying to update to v26.1.1 exactly where I get the error, because you're requiring the version to be < 4.65

ah, I see, Renovate still had 26.1.1 as pending because of its age. Ok, got it. I see the correct constraints in current version / 26.1.1. Sorry for the noise

@apeabody
Copy link
Collaborator Author

Thanks for the update @wyardley, glad its now working! :) Yes, I was about to mention #1640 only went in a few hours ago.

CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants