Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow ACM module to work w/o metrics sa #1634

Merged
merged 5 commits into from
May 16, 2023

Conversation

jmymy
Copy link
Contributor

@jmymy jmymy commented May 11, 2023

changes here: #1529 add support for a metrics SA. However if you dont enable the metrics SA the module doesn't work (possibly only when upgrading from an older version).

│ Error: Invalid index

│ on .terraform/modules/acm/modules/acm/creds.tf line 112, in resource "google_project_iam_member" "acm_metrics_writer_sa_role":
│ 112: member = "serviceAccount:${google_service_account.acm_metrics_writer_sa[0].email}"
│ ├────────────────
│ │ google_service_account.acm_metrics_writer_sa is empty tuple

│ The given key does not identify an element in this collection value: the
│ collection has no elements.


│ Error: Invalid index

│ on .terraform/modules/acm/modules/acm/outputs.tf line 37, in output "acm_metrics_writer_sa":
│ 37: value = google_service_account.acm_metrics_writer_sa[0].email
│ ├────────────────
│ │ google_service_account.acm_metrics_writer_sa is empty tuple

│ The given key does not identify an element in this collection value: the
│ collection has no elements.

Operation failed: failed running terraform plan (exit 1)

@jmymy jmymy marked this pull request as ready for review May 11, 2023 11:08
@jmymy jmymy requested review from a team, Jberlinsky and ericyz as code owners May 11, 2023 11:08
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody self-assigned this May 16, 2023
@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jmymy!

@apeabody apeabody merged commit 83a8be2 into terraform-google-modules:master May 16, 2023
@jmymy jmymy deleted the acm-fix branch May 17, 2023 12:48
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants