feat: Add support for Logging Variant to enable max throughput option #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyfoss
changed the title
|
@Jberlinsky @ericyz could you, please, review this MR? |
|
Note for myself:
|
|
LGTM and will approve once passing the integration test |
|
/gcbrun |
4 similar comments
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
This commit will be reverted after the test
ericyz
force-pushed
the
loggingvariant
branch
from
4a00d00 to
5208399
Compare
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
5 similar comments
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
/gcbrun |
ericyz
force-pushed
the
loggingvariant
branch
from
922719a to
f04aa6f
Compare
|
/gcbrun |
2 similar comments
|
/gcbrun |
|
/gcbrun |
ericyz
approved these changes
Sep 12, 2023
ericyz
approved these changes
Sep 12, 2023
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…terraform-google-modules#1616) Co-authored-by: Eric Zhao <[email protected]> Co-authored-by: Eric Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added logging_variant variable for node pools configuration to the autogen files