Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use provided service_account_name if available #1610

Merged
merged 4 commits into from
Apr 26, 2023
Merged

fix: use provided service_account_name if available #1610

merged 4 commits into from
Apr 26, 2023

Conversation

griseau
Copy link
Contributor

@griseau griseau commented Apr 17, 2023

Fixes #1609

@griseau griseau requested review from a team, Jberlinsky and ericyz as code owners April 17, 2023 08:40
@griseau griseau mentioned this pull request Apr 17, 2023
Merged
@apeabody
Copy link
Collaborator

/gcbrun

@griseau
Copy link
Contributor Author

griseau commented Apr 17, 2023

Hey @apeabody,

I see that terraform-google-kubernetes-engine-int-trigger action failed but I don't have the possibility to see the reason it's failing, so can't fix it :/

@apeabody
Copy link
Collaborator

Hey @apeabody,

I see that terraform-google-kubernetes-engine-int-trigger action failed but I don't have the possibility to see the reason it's failing, so can't fix it :/

Thanks @griseau - It appeared to be a flaky test run, no issues on the second run.

apeabody
apeabody requested changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @griseau!

Can you please run make build to build the terraform and docs.

autogen/main/sa.tf.tmpl Outdated Show resolved Hide resolved
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

@griseau
Copy link
Contributor Author

griseau commented Apr 20, 2023

Hey @apeabody,
Anything else required here ? Would we be able to have it in the next release ? :)

apeabody
apeabody approved these changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @griseau!

@apeabody apeabody merged commit a42ed88 into terraform-google-modules:master Apr 26, 2023
@apeabody
Copy link
Collaborator

Hey @apeabody, Anything else required here ? Would we be able to have it in the next release ? :)

Yup, will be included in the next release.

@michaellzc michaellzc mentioned this pull request Nov 23, 2023
Merged
@yorik yorik mentioned this pull request May 14, 2024
Closed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@griseau
fix: use provided service_account_name if available (terraform-google…
0b40d96 
…-modules#1610)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Service account created doesn't have the correct name
2 participants
@griseau @apeabody