-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Remove 1.23 restriction on workload identity module #1595
Fix: Remove 1.23 restriction on workload identity module #1595
Conversation
729fcd0
to
0b617f5
Compare
0b617f5
to
9bcfc39
Compare
/gcbrun |
looks like the CI failure (https://console.cloud.google.com/cloud-build/builds;region=global/4191051c-4ffc-4779-9adc-73ede3c8d710;step=94?e=-13802955&jsmode=o&mods=logs_tg_prod&project=cloud-foundation-cicd) is
I think this is pre-existing, I'm seeing this job fail on other PRs as well is there an issue and ETA for resolving the CI break at HEAD? |
Thanks @liggitt! @bharathkkb, I opened #1597 |
looks like the rerun passed, and the |
Yes, looks like some CI flakiness as both this and my test PR just passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @liggitt! LGTM!
thanks! any chance of pulling this into a 25.1.0 patch release ahead of 26.0.0? |
Let me discuss with @bharathkkb, but I think we might be able to make the next release |
@liggitt @apeabody IIUC The We have now also bumped the min constraint to |
Interesting, thanks for that clarification. It's surprising a minor version dependency bump for a downstream bugfix requires a major version change here, but I'm glad existing consumers can use against 1.24+ successfully without any changes here |
Thanks @bharathkkb! That was going to be my question with regards to it being a non-Google provider. |
Hi @liggitt, yes good call by @bharathkkb that it was the module README.md and example used for CI which were pinned to |
The issue with hashicorp/kubernetes hanging creating service accounts was resolved in hashicorp/terraform-provider-kubernetes#1792 in https://github.com/hashicorp/terraform-provider-kubernetes/releases/tag/v2.13.0
This reverts the temporary limitation of the workload identity module to 1.23 added in #1315 to resolve #1313, and updates the minimum required version of hashicorp/kubernetes to 2.13.0 for the workload-identity module
Fixes #1582
cc @bharathkkb @apeabody
BEGIN_COMMIT_OVERRIDE
Fix(kubernetes ~> 2.13)!: Remove 1.23 restriction on workload identity module (#1595)
END_COMMIT_OVERRIDE