Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow setting network tags on autopilot clusters #1572

Merged
merged 3 commits into from
Mar 1, 2023
Merged

feat: allow setting network tags on autopilot clusters #1572

merged 3 commits into from
Mar 1, 2023

Conversation

gtsorbo
Copy link
Contributor

@gtsorbo gtsorbo commented Feb 23, 2023

@gtsorbo gtsorbo requested review from a team, Jberlinsky and ericyz as code owners February 23, 2023 21:42
@gtsorbo
Copy link
Contributor Author

gtsorbo commented Feb 24, 2023

/gcbrun

1 similar comment
@gtsorbo
Copy link
Contributor Author

gtsorbo commented Feb 24, 2023

/gcbrun

@gtsorbo
Copy link
Contributor Author

gtsorbo commented Feb 27, 2023

/gcbrun

ericyz
ericyz approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@ericyz ericyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericyz
Copy link
Collaborator

ericyz commented Mar 1, 2023

@apeabody @bharathkkb - would you like to pair review and merge when ready. Thanks

apeabody
apeabody approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apeabody apeabody merged commit 23e9c96 into master Mar 1, 2023
@apeabody apeabody deleted the feat/node-auto-config-network-tags branch March 1, 2023 18:36
@release-please release-please bot mentioned this pull request Mar 1, 2023
Merged
@gtsorbo gtsorbo mentioned this pull request Mar 1, 2023
Closed
@michaellzc michaellzc mentioned this pull request Nov 23, 2023
Merged
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@gtsorbo
feat: allow setting network tags on autopilot clusters (terraform-goo…
92d54ba 
…gle-modules#1572)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@ericyz ericyz ericyz approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gtsorbo @ericyz @apeabody