Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node_metadata mapping for GCE_METADATA (#1542) #1543

Merged
merged 1 commit into from
Feb 14, 2023
Merged

fix: node_metadata mapping for GCE_METADATA (#1542) #1543

merged 1 commit into from
Feb 14, 2023

Conversation

fcrespel
Copy link
Contributor

This PR fixes the issue described in #1542: the legacy EXPOSE value for node_metadata should be mapped to the new GCE_METADATA value instead of the opposite, and GCE_METADATA should be left as is.

@fcrespel fcrespel requested review from a team, Jberlinsky and ericyz as code owners January 24, 2023 21:20
@fcrespel fcrespel changed the title Fix node_metadata mapping for GCE_METADATA (#1542) fix: node_metadata mapping for GCE_METADATA (#1542) Jan 24, 2023
@comment-bot-dev
Copy link

@fcrespel
Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb
Copy link
Member

Thanks for the PR @fcrespel

@bharathkkb bharathkkb merged commit b03ea84 into terraform-google-modules:master Feb 14, 2023
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants