Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auth module avoid TPG v4.49.0 #1535

Merged
merged 2 commits into from
Jan 20, 2023
Merged

fix: auth module avoid TPG v4.49.0 #1535

merged 2 commits into from
Jan 20, 2023

Conversation

apeabody
Copy link
Collaborator

Fixes #1533

@apeabody apeabody requested review from a team, Jberlinsky and ericyz as code owners January 18, 2023 20:53
@apeabody apeabody changed the title fix: avoid TPG v4.49.0 fix: auth module avoid TPG v4.49.0 Jan 18, 2023
bharathkkb
bharathkkb approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @apeabody Looks like we need to pin for this example too

terraform-google-kubernetes-engine/test/fixtures/safer_cluster_iap_bastion/example.tf

Line 33 in 912da8c

data "google_container_cluster" "safer" {

@comment-bot-dev
Copy link

@apeabody
Thanks for the PR! 🚀
✅ Lint checks have passed.

@apeabody apeabody merged commit 95c5c11 into master Jan 20, 2023
@apeabody apeabody deleted the apeabody-patch-1 branch January 20, 2023 15:59
@release-please release-please bot mentioned this pull request Jan 20, 2023
Merged
@michaellzc michaellzc mentioned this pull request Nov 23, 2023
Merged
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@apeabody
fix: auth module avoid TPG v4.49.0 (terraform-google-modules#1535)
6f50676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auth module crash with 4.49 google provider
3 participants
@apeabody @comment-bot-dev @bharathkkb